Make directRenderScript the default #11791
Conversation
🦋 Changeset detectedLatest commit: e996921 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
github-actions
bot
added
the
pkg: integration
There was a problem hiding this comment.
Thanks @bluwy , super amazing changeset here!
As for your questions, anything on the upgrade guide page itself, feel free to commit directly! Yes, we'll need this kind of advice, so we should probably put a breaking changes entry in for this one (even though I've already covered the general unflagging of all the newly stable things, this one needs extra guidance).
For more general updates throughout the docs, a PR is great because it calls more attention (to me) as to what kinds of changes are necessary, and are more likely to stick in my mind as I basically have to go through ALL the docs for all kinds of new stuff everywhere 😅 Would love for you to go through and PR some updates, and then even if you don't catch all of them, we have an idea of what kind of changes to be on the lookout for in case we spot something that isn't as obvious and doesn't return a direct search hit.
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
Make
directRenderScriptthe default and removes previous hoisted script handling.Testing
The tests should pass. I edited most of the tests to not test against hoisting behaviour anymore, and to not mention the word "hoisted"
Docs
Would appreciate review of the changesets in the PR!
On the docs repo side, this will require a migration guide, which users have to check that their scripts are still working as expected. The general docs may also need to be updated to not reference the "hoisting to head" behaviour of scripts. (Question: should I commit this other change to the
v5-betabranch directly, or via PR?)